feat: add blas/base/dspr
#2794
Merged
feat: add blas/base/dspr
#2794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
the
BLAS
kgryte
added
the
Needs Changes
aman-095
added
Needs Review
aman-095
added
Needs Review
kgryte
approved these changes
Aug 18, 2024
There was a problem hiding this comment.
LGTM. Thanks, @aman-095.
One small comment: I updated the tests to use exact equality, rather than approximate equality, as this API only involves simple addition and multiplication, resulting in whole numbers. Should results include decimal values, then approximate equality is more appropriate.
gunjjoshi
pushed a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2794 Ref: stdlib-js#2039 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #2039.
Description
This RFC proposes to add a routine to the symmetric rank 1 operation
A = α*x*x^T + Awhereαis a scalar,xis anNelement vector, andAis anNbyNsymmetric matrix supplied in packed form as defined in BLAS Level 2 routines. Specifically adding@stdlib/blas/base/dspris proposed.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers